Move notification API into main commons codebase #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled the notifications API calls (
getAllNotifications()andmarkRead()) out of the data client and moved them into their ownNotificationInterfacein the main commons codebase. I setup injection to pass theNotificationInterfaceinto the client instead of the large Service interface from the data-clientI also converted the
NotificationClientto Kotlin and updated its unit test to add extra verification of the mapping of all of the fields from the Wikimedia notification object to our own one. The meant adding a few setters to the model objects (that previously were only set by reading JSON off the wire).This relates to the discussion in #5165