Replace Mapbox with OSMDroid (Explore Activity) #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
nicolas-raoul
approved these changes
Jan 27, 2024
| * a) Creates bottom sheet behaviours from bottom sheet, sets initial states and visibility | ||
| * b) Gets the touch event on the map to perform following actions: | ||
| * if bottom sheet details are expanded or collapsed hide the bottom sheet details. | ||
| * a) Creates bottom sheet behaviours from bottom sheet, sets initial states and visibility b) |
There was a problem hiding this comment.
I think this javadoc was more readable before.
There was a problem hiding this comment.
Sure and Thanks !, Sorry I did not see that. Shared a pull request #5481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Replace Mapbox with OSMDroid in Explore Activity
Fixes #5458
What changes did you make and why?
Tests performed (required)
Tested
prodDebugon Samsung S21 FE with API level 33.Screenshots (for UI changes only)
https://github.com/commons-app/apps-android-commons/assets/114223204/6dca5d00-bf1b-44f4-90e6-31625d0a72d1