Move login client into main commons codebase #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the discussion in #5165
To keep the change-set as simple as possible, this only moves the
LoginClient, its service API (plus request/responses), and a related unit test into the main commons code base with no modification to its behaviour. Conversion to Kotlin will follow in another PR.Note: the "logout" client was unused in the app, so it was deleted for clarity.
Eventually, the "App Adapter" abstraction will go away, since we wont be using the data-client module. For now, since the LoginClient / LoginResponse is moving and all the callers are inside our own code, just a single method was removed.