Removed references to the data-client ServiceFactory #5496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces our own
CommonsServiceFactory
for creating Retrofit API service interfaces, allowing us to decouple from the data-clientServiceFactory
implementation.In another step of dead code removal, the wikiSite parameter was deleted from the AppAdaptor as it was unused, allowing a slightly cleaner implementation of the service factory on our side, managed by Dagger as a singleton.
This PR relates to the discussion in #5165