Fix-Peer Review Buttons not get disabled after voting an Image for deletion #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Feb 14, 2024
There was a problem hiding this comment.
I noticed a bug:
- At question
Does this follow the rules of copyright?, tapNo. The buttons are correctly disabled. - Continue reviewing the next picture.
- At question
Does this follow the rules of copyright?, the buttons are incorrectly already disabled, before I have a chance to tap any for that picture.
nicolas-raoul
requested changes
Feb 14, 2024
|
@nicolas-raoul thanks for reviewing and finding this bug, will make changes to fix this |
|
@nicolas-raoul If these changes I made works then can you review this PR please, thanka |
|
@nicolas-raoul Just Pinging In case you missed it, Please Review |
|
Apologies, I have been trying to peer review until I see a bad image to delete, but the uploads are all good... |
nicolas-raoul
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5516
What changes did you make and why?
Peer Review Buttons ("Yes" and "No") gets disabled to after nominating an Image for deletion to avoid Incorrect Input from user.
Tests performed (required)
Tested 4.2.1-debug-main on Xiaomi 11 Lite NE with API level 33
Screenshots (for UI changes only)
WhatsApp.Video.2024-02-05.at.6.29.07.PM.mp4