Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the centrality and size of the
UploadClient
this PR was split out the work of converting clients to Kotlin to make sure all is good and verifiable.Getting good tests around the
UploadClient
meant some refactoringContribution
class a little more OO by encapsulating logic that was touching its internal stateFileUtilsWrapper
with a context (provided by Dagger in the real production code) to remove the context from the helper method interfaceOnce the test was in place around the Java version, it provided safety to convert the Java implementation to Kotlin and verify that none of its behavior had changed.
Note: this relates to the discussion in #4665