Feat : Added a feature for users to add feadback on github #5578
Conversation
|
|
||
| setUserName(); | ||
| return binding.getRoot(); | ||
| } | ||
|
|
||
| private void onFeedbackGithubClicked() { | ||
| final String url = "https://github.com/commons-app/apps-android-commons/issues"; |
There was a problem hiding this comment.
can you make this a string constant?
There was a problem hiding this comment.
fixed. Thanks for the feedback.
|
@nicolas-raoul Sorry to ping after the PR has been merged, but this PR has two test cases failing here:
This is causing the tests to fail on all other PRs. Also, while I was testing the main branch, I was surprised to see that this PR was merged, when there was still some discussion going on here about the best possible UI for feedback on GitHub. And as mentioned there, even you didn't approve of the concept of having 2 separate menu items. |
|
Thanks @ShashwatKedia for pointing this out! I agree two menu items is not ideal, but I felt that it was still better than nothing. |
|
git bisect says 3d1efec is the first commit where unit tests start failing. |
|
Oh, thanks and sorry, @nicolas-raoul, that you had to perform git bisect for this. I'll look into this and try to perform the actions required by PR without failing the tests |
Um, what do you think about the solution proposed here ? |
Description
Approach
It gives the users an ability to place feedbacks (issues, new feature) directly on the github from the app.
Testing Instructions
Screenshots/ Working Video
feedback.on.github.mp4
Tests performed
Test performed on Google Pixel 4 (Emulator).
Feel free to place your opinion.