Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Image From Upload Wizard #5636

Merged
merged 6 commits into from
Mar 24, 2024

Conversation

shashankiitbhu
Copy link
Contributor

Description (required)

Fixes #5630

What changes did you make and why?
Added Option to Remove Image From Upload Wizard by clicking on a Cross Icon

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots (for UI changes only)

WhatsApp Image 2024-03-22 at 1 41 07 AM

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge case bug: When removing the last pic in a multi-upload, then going to previous, top bar not visible anymore.

screen-20240322-223245.mp4

@shashankiitbhu
Copy link
Contributor Author

@nicolas-raoul good catch, I'll look into it now, thanks

@shashankiitbhu
Copy link
Contributor Author

@nicolas-raoul fixed it, Please Review

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small bug when removing the last pic:

screen-20240324-104400.mp4

@shashankiitbhu
Copy link
Contributor Author

@nicolas-raoul thanks for spotting it, fixed it in the latest commit, Please Review

@shashankiitbhu
Copy link
Contributor Author

WhatsApp.Video.2024-03-24.at.12.09.37.PM.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Remove Specific Images from Upload Wizard
2 participants