Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes App crashes on clicking Save (EditActivity) #5670

Merged
merged 66 commits into from
Mar 30, 2024

Conversation

kanahia1
Copy link
Contributor

Description (required)

Fixes #5632

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung S21 FE with API level 33.

Screenshots (for UI changes only)
Tested on same picture as in #5632

WhatsApp.Video.2024-03-28.at.21.02.47_9bd61241.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more crash, thanks!
Saving still fails, but I guess that's another issue?

@neeldoshii
Copy link
Contributor

Thank you for the contribution.

This does indeed solve the app crash, but still few nitpicks

  1. You have 66 commits can you perform git reset and have one.
  2. The reason I am not convinced in this is because this PR Fix custom picker not consider rotated image #5569 solves exif null pointer as well as it handles the saving of rotated image. Would you mind updating the code to saving the rotated image and also considering Fix custom picker not consider rotated image #5569 (comment) to fix security issues of exif data.

@kanahia1
Copy link
Contributor Author

kanahia1 commented Mar 29, 2024

@nicolas-raoul, Thanks for the review. Sure we can open a new issue for the saving.

@nicolas-raoul nicolas-raoul merged commit 7dd00ef into commons-app:main Mar 30, 2024
1 check passed
@nicolas-raoul
Copy link
Member

It is true that git rebase would have made the commits of this PR cleaner. I suggest always running it before sending a PR, it not only makes review easier, but can help contributors spot problems that would otherwise be hard to notice.

@neeldoshii Would you like to create an issue (and possibly PR) for what you think are the next steps on this? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App crashes on clicking Save (EditActivity)
3 participants