Adds a 'Remove Location' button to the UploadWizard #5247 #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-raoul I didn't add my commits on top of #5348 as it had merge conflicts in almost every file, hope that is not an issue :) |
nicolas-raoul
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
Tested by uploading https://commons.m.wikimedia.org/wiki/File%3ATaille-crayon_pour_crayon_pastel.jpg it correctly removed the location from EXIF:
|
@nicolas-raoul could we close #5348 and #5262 as the issue is solved now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
The UploadWizard did not provide the user with any option to remove the location from the image. This PR aims to solve this issue and provide a button to remove the location from the image to maintain the user's privacy
Fixes #5247
What changes did you make and why?
Added a new 'Remove Location' button to the LocationPickerActivity. Also, disables NoLocationDialog, if the user has removed the location for the current image, as requested here
Tests performed (required)
Tested prodDebug on OnePlus Nord CE 2 Lite with API level 31.
Screencast
video6071180222743455571.mp4
Special thanks to @paco-arana and @shankarpriyank for their amazing PRs :)