Fixed issue #812

[ftsalamp]

Fixed issue #812 using Approach A.

[codecov-io]

Codecov Report

Merging #842 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #842      +/-   ##
=========================================
- Coverage     6.9%   6.85%   -0.05%     
=========================================
  Files          95      95              
  Lines        5071    5105      +34     
  Branches      472     477       +5     
=========================================
  Hits          350     350              
- Misses       4694    4728      +34     
  Partials       27      27

Impacted Files	Coverage Δ
...fr/free/nrw/commons/settings/SettingsFragment.java	45.94% <ø> (ø)	⬆️
...java/fr/free/nrw/commons/upload/ShareActivity.java	0% <0%> (ø)	⬆️
...mmons/contributions/ContributionsListFragment.java	0% <0%> (ø)	⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d3f05...22ff940. Read the comment docs.

[neslihanturan]

Thanks for this PR @ftsalamp .
According to my tests on android 5.0.2:

• It works as intended, saves the photo to gallery on cancellation of upload.
  However, tests on android 4.2.2:
• Failed with security exception, gallery is stopped. With such error:
  java.lang.SecurityException: Permission Denial: opening provider android.support.v4.content.FileProvider from ProcessRecord{42992670 2928:com.android.gallery3d/u0a52} (pid=2928, uid=10052) that is not exported from uid 10151

[neslihanturan]

This is a quite important fix, however need some small changes to pass tests. I want to edit this PR to merge it as soon as possible, however there is several approaches to edit someone else's PR. Does anyone can tell me the best approach, to make our commit history clean?

[nicolas-raoul]

@neslihanturan

1. Have the person git rebase to master, if possible
2. Create a feature branch with the same name from the same point
3. Pull from their branch
4. Do as if it were yours

I would say.
Here ftsalamp worked directly in master, but I suggest you create a feature branch for it.

[neslihanturan]

Thanks @nicolas-raoul , but I have a small uncertainty. Since this changes on master branch of ftsalamp's fork, and you said create a feature branch from same point, with same name, what should be the name of the new feature branch?

[nicolas-raoul]

How about something like bugfix-812 ?

…

On Sep 9, 2017 15:58, "neslihanturan" ***@***.***> wrote: Thanks @nicolas-raoul <https://github.com/nicolas-raoul> , but I have a small uncertainty. Since this changes on master branch of ftsalamp's fork, and you said create a feature branch from same point, with same name, what should be the name of the new feature branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#842 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGFBgFoeukyE8w0Z6knWZoXtukVPcNwks5sglM2gaJpZM4O0GIo> .

[neslihanturan]

It seems like my tests failed because of a problem that exists on master branch too. So I decided to resolve that issue on another PR. For now, I only resolved conflicts to be able to merge this changes. Thanks for this changes @ftsalamp .

[misaochan]

@neslihanturan Shall we close this so we can focus on #876 ?