Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bootstrap v4.1 stable? #29

Closed
sivaraam opened this issue May 11, 2018 · 5 comments
Closed

Switch to bootstrap v4.1 stable? #29

sivaraam opened this issue May 11, 2018 · 5 comments

Comments

@sivaraam
Copy link
Member

Bootstrap v4 alpha has been outdated according to the website. How about switching to the stable v4.1?

@nicolas-raoul
Copy link
Member

@sivaraam Yes sure :-)
Do you want to do it?

@sivaraam
Copy link
Member Author

Do you want to do it?

Sure, when I get time! I would going out of town for a week. So, I'll try to do it when I find time.

@sivaraam
Copy link
Member Author

sivaraam commented Jun 3, 2018

I have a little doubt now. Do we require the navbar? Given that,

  1. The page it self is not too long and
  2. All the links in the navbar link only to different sections of the page and
  3. The navbar seems to be the only component requiring javascript

Should we better remove the navbar? Removing it would make the page become independent of the javascript resources which might in turn reduce the load time.

@misaochan
Copy link
Member

I personally find the nav bar very helpful, especially if we plan on expanding the page's content in the future. But I'm not a web dev. :)

@sivaraam
Copy link
Member Author

sivaraam commented Jun 7, 2018

In that case, I'll keep the resolution for this focused only for switching to v4.1 and I'll see if I could do something about the navbar separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants