Switch to Bootstrap v4.1.1 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates the site to use a stabler and newer version of Bootstrap (v4.1.1) from the deprecated v4-alpha. This has a few side effects as noted below: - The navigation bar was tweaked a little to make it suit well with the newer version of the framework. While at it, the website title was moved to the left in smaller screens ensure it doesn't clash with the hamburger menu. - The external script tags for the newer version were moved to the end of the document to ensure they don't affect the page loading a lot. (The script is required only for the hamburger menu, shown in mobile devices) - Somme inline styles were moved to the stylesheet for the sake of consistency.
|
Could be tested live at https://sivaraam.github.io/commons-app.github.io/ |
|
Just FYI, I've used https://sivaraam.github.io/commons-app.github.io/ to host the changes of #31 for now. |
|
Ok, I just noticed a mild inconsistency in this change. The navbar isn't fixed anymore. Is that ok, or should I bring back the stickness? |
|
Hi, It's been a long time since the change has been approved. Why hasn't it been approved yet? |
|
Sorry about the delay. I am really not familiar with web dev, but since @tobias47n9e approved it, I will go ahead and merge. (He is the maintainer for the website AFAIK) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the site to use a stabler and newer version of
Bootstrap (v4.1.1) from the deprecated v4-alpha. This has a few
side effects as noted below:
The navigation bar was tweaked a little to make it suit well with
the newer version of the framework. While at it, the website title
was moved to the left in smaller screens ensure it doesn't clash
with the hamburger menu.
The external script tags for the newer version were moved to the
end of the document to ensure they don't affect the page loading
a lot. (The script is required only for the hamburger menu, shown
in mobile devices)
Somme inline styles were moved to the stylesheet for the sake of
consistency.
Fixes: #29