refactor: features section #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArshdeepGrover
approved these changes
May 1, 2024
ArshdeepGrover
requested changes
May 14, 2024
...admin/src/app/feature-modules/features/components/features-index/features-index.component.ts
Outdated
Show resolved
Hide resolved
...admin/src/app/feature-modules/features/components/features-index/features-index.component.ts
Show resolved
Hide resolved
apps/commudle-admin/src/app/feature-modules/features/components/features/features.component.ts
Outdated
Show resolved
Hide resolved
apps/commudle-admin/src/app/feature-modules/features/components/features/features.component.ts
Outdated
Show resolved
Hide resolved
apps/commudle-admin/src/app/feature-modules/features/components/features/features.component.ts
Outdated
Show resolved
Hide resolved
apps/commudle-admin/src/app/feature-modules/features/components/features/features.component.ts
Outdated
Show resolved
Hide resolved
ArshdeepGrover
requested changes
May 28, 2024
...admin/src/app/feature-modules/features/components/features-index/features-index.component.ts
Outdated
Show resolved
Hide resolved
ArshdeepGrover
approved these changes
May 28, 2024
ArshdeepGrover
requested changes
Jun 4, 2024
| </li> | ||
| <li> | ||
| <div class="icon"> | ||
| <!-- <fa-icon [icon]="faChartLine"></fa-icon> --> |
There was a problem hiding this comment.
let's remove if not required
| </li> | ||
| <li> | ||
| <div class="icon"> | ||
| <!-- <fa-icon [icon]="faHandsHoldingCircle"></fa-icon> --> |
There was a problem hiding this comment.
let's remove if not required
Comment on lines
137
to
155
| id: 144, | ||
| url: 'https://json.commudle.com/rails/active_storage/blobs/redirect/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBM2sxQWc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--401df19785a101dbb8c939863455bd55d6f49d60/razorpay.svg', | ||
| }, | ||
|
|
||
| features_page_header: { | ||
| id: 147, | ||
| url: 'https://json.commudle.com/rails/active_storage/blobs/redirect/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBN3BOQWc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--3d98e63d356d788a6483ed7067ba6b0b5fe0eaf8/Header%20Section.png', | ||
| }, | ||
|
|
||
| features_know_your_community: { | ||
| id: 148, | ||
| url: 'https://json.commudle.com/rails/active_storage/blobs/redirect/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBN3hOQWc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--48d2e70f97d92111d9cb7d39cad41db00d1b0fb9/Section%203%20Image.png', | ||
| }, | ||
|
|
||
| features_build_your_community: { | ||
| id: 149, | ||
| url: 'https://json.commudle.com/rails/active_storage/blobs/redirect/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBNzFOQWc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--b38292eb21e0b5bf7fd7115cdbe50e6fe6ab4078/Section%204.png', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
let's use id in the comment instead making object of URL and id
ArshdeepGrover
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template
Type
description
Screenshots
Bundle Size