Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connect SSO after login (closes #52) #58

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

kimlimjustin
Copy link
Contributor

Giving the ability for users to connect their SSO after creating accounts using passwords, simply by going to the account page and click the button "Link my account with [provider]"

image
^ Example with google as a provider

Copy link

github-actions bot commented Jun 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kimlimjustin
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kimlimjustin
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Jun 17, 2024
Copy link
Collaborator

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks, just a couple review notes.

Also, we should probably add a way to disconnect a provider soon after this.

src/routes/auth/v1/oidc/logout/+page.svelte Outdated Show resolved Hide resolved
src/routes/auth/v1/account/+page.svelte Outdated Show resolved Hide resolved
@kimlimjustin
Copy link
Contributor Author

Thanks for the fast response, it was my bad and I've edited them.

Also, we should probably add a way to disconnect a provider soon after this.

In my mind, we'll also need the option to add a password for an SSO-registered account too, wdyt? I'll probably send another PRs regarding this asap

@zicklag
Copy link
Collaborator

zicklag commented Jun 17, 2024

In my mind, we'll also need the option to add a password for an SSO-registered account too, wdyt? I'll probably send another PRs regarding this asap

Yeah, definitely.

I think the way it works in Rauthy is:

  • If you're connected to an SSO provider, you can click a button to disconnect, and it will send you a password reset email to set your password.
  • If you aren't connected to an SSO provider, then it shows the buttons to connect to one ( like you have it already with this PR )

That means you can only connect to one provider at a time, which is how Rauthy works I think.


Oh, one other thought, it'd be good to have the logos for the SSO providers to connect to in the link buttons.

But I'll merge this now, thanks again!

@zicklag zicklag merged commit e6cfc54 into commune-os:main Jun 17, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants