-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connect SSO after login (closes #52) #58
feat: connect SSO after login (closes #52) #58
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks, just a couple review notes.
Also, we should probably add a way to disconnect a provider soon after this.
Thanks for the fast response, it was my bad and I've edited them.
In my mind, we'll also need the option to add a password for an SSO-registered account too, wdyt? I'll probably send another PRs regarding this asap |
Yeah, definitely. I think the way it works in Rauthy is:
That means you can only connect to one provider at a time, which is how Rauthy works I think. Oh, one other thought, it'd be good to have the logos for the SSO providers to connect to in the link buttons. But I'll merge this now, thanks again! |
Giving the ability for users to connect their SSO after creating accounts using passwords, simply by going to the account page and click the button "Link my account with [provider]"
^ Example with google as a provider