Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-3535/FS-4340: implementation of the SQS extended client for the assessment store #475

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

nuwan-samarasinghe
Copy link
Contributor

@nuwan-samarasinghe nuwan-samarasinghe commented Jun 3, 2024

https://dluhcdigital.atlassian.net/browse/FS-3535
https://dluhcdigital.atlassian.net/browse/FS-4340

Change description

assessment store sqs extended client changes to send messages to notification service queue

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

This should successfully import the completed applications which is in the SQS queue

Screenshots of UI changes (if applicable)

@nuwan-samarasinghe nuwan-samarasinghe changed the title FS-3535: implementation of the SQS extended client for the assessment store FS-3535/FS-4340: implementation of the SQS extended client for the assessment store Jun 4, 2024
Copy link
Contributor

@srh-sloan srh-sloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments around whether we can reuse more stuff that's in notify. Happy to discuss.

_helpers/context_aware_executor.py Outdated Show resolved Hide resolved
_helpers/task_executer_service.py Outdated Show resolved Hide resolved
@nuwan-samarasinghe nuwan-samarasinghe merged commit 1ffe025 into main Jun 5, 2024
18 checks passed
@nuwan-samarasinghe nuwan-samarasinghe deleted the FS-3535-sqs-extended-client-implementation branch June 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants