Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS-3873: Cookies page and banner on assessment #646

Merged
merged 4 commits into from
Jun 24, 2024
Merged

FS-3873: Cookies page and banner on assessment #646

merged 4 commits into from
Jun 24, 2024

Conversation

hamzabinkhalid
Copy link
Contributor

@hamzabinkhalid hamzabinkhalid commented Jun 24, 2024 •
edited
Loading

https://dluhcdigital.atlassian.net/browse/FS-3873
https://dluhcdigital.atlassian.net/browse/FS-3874

Change description

  • Cookie Policy page added

  • Route to cookie policy page added

  • Cookie banner added with accept and reject options

  • Unused JS functions removed

  • Show all sections and show are being rendered by the govuk frontend in the version being used

  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

  • Go to the assessment dashboard, you should be prompted to accept or reject the cookies in the form of a banner.
  • It should retain info what choice you made for the duration of your session
  • Observe the details in the dev tools to see cookies being created
  • Verify you are able to visit the cookies page, read and make a choice from there as well

Screenshots of UI changes (if applicable)

Screenshot 2024-06-24 at 06 05 32 Screenshot 2024-06-24 at 06 05 58 Screenshot 2024-06-24 at 06 06 18

@hamzabinkhalid
FS-3873:
655f84d 
- Cookie Policy page added
- Route to cookie policy page added
- Cookie banner added with accept and decline options
- Unused JS functions removed
- Show all sections and show are being rendred by the govuk frontend in the version being used
@hamzabinkhalid
- static_url_path removed
6d11b2e
@hamzabinkhalid
- style adjusted because of login page
94d60dc
@hamzabinkhalid
- govuk-width-container-original remvoed as not used
dc6e77f
@hamzabinkhalid hamzabinkhalid requested a review from a team June 24, 2024 05:13
@hamzabinkhalid hamzabinkhalid merged commit a079b1c into main Jun 24, 2024
14 checks passed
@hamzabinkhalid hamzabinkhalid deleted the FS-3873-cookies-Policy-PageAndBanner branch June 24, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srh-sloan srh-sloan srh-sloan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamzabinkhalid @srh-sloan