FS-1015 - Logging utility, config defaults and initialisation added #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harryyo
commented
Jun 15, 2022
•
harryyo
commented
- Logging utility added
- Colour coded text logs to console in development
- Json logs in other environments
- Gunicorn support added
- Manifests for dev and test updated to use gunicorn rather than Flask run
… updates to support service running with gunicorn. Dev config updated to set FSD_LOG_LEVEL to debug
harryyo
requested review from
sentienthouseplant,
gidsg,
Adam-W1,
gio-karunakaran,
ramsharma-prog,
rayhan15243 and
srh-sloan
|
Some values are coming through as We should either fix these or remove them. |
…imezone log time added and maded consistent across gunicorn and application logs, gunicorn config script location refactored
gidsg
reviewed
Jun 20, 2022
gidsg
reviewed
Jun 20, 2022
sentienthouseplant
approved these changes
Jun 20, 2022
Adam-W1
reviewed
Jun 20, 2022
|
|
||
| First set the FLASK_ENV environment you wish to test eg: | ||
|
|
||
| export FLASK_ENV=dev |
There was a problem hiding this comment.
im wondering if this should be stated outside of the 'Run with Gunicorn' section as it applies to running in Flask also
Adam-W1
reviewed
Jun 20, 2022
| @@ -0,0 +1,365 @@ | |||
| from __future__ import absolute_import | |||
There was a problem hiding this comment.
Is this another candidate for our shared utils?
sentienthouseplant
approved these changes
Jun 20, 2022
gidsg
approved these changes
Jun 20, 2022
gidsg
reviewed
Jun 21, 2022
Comment on lines
+153
to
+156
| def now(self): | ||
| return datetime.datetime.now( | ||
| tz=pytz.timezone("Europe/London") | ||
| ).strftime("%d-%b-%y %H:%M:%S") |
There was a problem hiding this comment.
I think this is unused now so can be safely deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.