Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-1628 Add AZURE_TENANT_ID to config #81

Merged
merged 13 commits into from
Oct 19, 2022

Conversation

harryyo
Copy link
Contributor

@harryyo harryyo commented Oct 14, 2022

AZURE_AD_TENANT_ID env var added to configs, used to form AZURE_AD_AUTHORITY url, and passed through via github secrets, workflow and manifests

@harryyo harryyo requested a review from gidsg October 14, 2022 18:26
We are no longer namespacing this with the environment
@harryyo harryyo temporarily deployed to Dev October 17, 2022 16:41 Inactive
…unitiesuk/funding-service-design-authenticator into fs-1628-update-azure-client-config
@harryyo harryyo temporarily deployed to Dev October 17, 2022 16:42 Inactive
@harryyo harryyo temporarily deployed to Dev October 17, 2022 16:43 Inactive
@harryyo harryyo temporarily deployed to Dev October 17, 2022 16:49 Inactive
@harryyo harryyo temporarily deployed to Dev October 19, 2022 13:04 Inactive
@harryyo harryyo temporarily deployed to Dev October 19, 2022 13:05 Inactive
@harryyo harryyo temporarily deployed to Dev October 19, 2022 13:10 Inactive
…THORITY url, and passed through via github secrets, workflow and manifests
…unitiesuk/funding-service-design-authenticator into fs-1628-update-azure-client-config
@harryyo harryyo temporarily deployed to Dev October 19, 2022 15:11 Inactive
@harryyo harryyo temporarily deployed to Dev October 19, 2022 15:12 Inactive
@harryyo harryyo temporarily deployed to Dev October 19, 2022 15:17 Inactive
Copy link
Contributor

@gidsg gidsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@harryyo harryyo merged commit 48e7efc into main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants