Adds a "vaurien-set-handler" command line utility. #1
Conversation
|
Thinking about it a bit, I'm even wondering if I want that into vaurien distribution. That could be handy to have this as a vaurien-client project, packaged separately. This would avoid to share dependencies (for instance, here I'm adding requests to the vaurien distribution, and if I just want to use the client, I'll get all the dependencies at the same time, even if I don't need them). what do you think? |
|
I think this is such a tiny project that it's overkill. And requests can be used on both sides no ? |
|
What do you mean "on both sides"? |
|
in the vaurien client and in the vaurien proxy |
| @@ -0,0 +1,54 @@ | |||
There was a problem hiding this comment.
there are 2 spaces indentation instead of 4
There was a problem hiding this comment.
oh, right! that was me trying to use sublime text 2. I'll fix this, thanks for the notice.
|
I don't think the vaurien proxy needs requests at all, only the client needs it, at least at the moment. Are you thinking about something in particular where requests could be interesing on the proxy side? |
|
no I just recall we use gevent' StreamServer. But requests is small and has no deps itself, I would not worry for now |
|
Just updated with the replacement of tabs with spaces. |
Also, vaurien.client.change_handler makes it easier for third parties to change the handler remotely.
|
what's the state of this branch ? |
|
Oh, here it was, so finally I didn't lost this. I think this is what you did again, right? If that's it, we probably can close it. |
|
yeah, that's kind of the same thing you did there with 43aa4d4 |
|
Yeah why not |
|
Implemented in 592685f |
Also, vaurien.client.change_handler makes it easier for third parties to change
the handler remotely.