New colorblind themes are much worse than normal ones

[Esaron]

Select Topic Area

Product Feedback

Body

I have mild protanopia, and upon enabling the new dark theme made for the condition, I realized that it's significantly harder to tell apart certain colors. Specifically, the new color used for the "Open" tag is completely indistinguishable from the crossmarks for failed checks. With my previous theme (Dark Dimmed), the colors are way easier to tell apart.

Example:

Dark Protanopia & Deuteranopia

Dark dimmed

[jge162]

You should definitely avoid the new theme

[Esaron]

That's the plan - it clearly isn't working for me. I just wanted to raise the issue in the hopes that maybe it improves. The blue checkmark vs new crossmark is really helpful. I just don't expect to see the same color for something positive/harmless (Open PR) and something negative (Failed/missing check).

[Esaron]

After using a color dropper, I realize that this isn't my condition, those colors really are the same... I don't expect to see the same color for something positive/harmless (Open PR) and something negative (Failed/missing check). Is this intended? Or should the "Open" tag be blue instead, like the checkmark? I'm guessing that color is used already for merges, but could the "Open" tag at least be green like it was before? That would be better than just picking the same color as a failing check.

[jge162]

I hope they see this and can make updates

[ghostinhershell]

Hi @Esaron and welcome to the GitHub community!

We appreciate you sharing your feedback on the new dark theme. I'll go ahead and loop in my colleague @benjiallen into this conversation. He may have additional questions for you.

Cheers!

[jordan-rddi]

I want to express a similar concern about the "Open" tag. The red seems like the wrong choice and doesn't appear to follow the rest of the interface either.

Another "tag" related problem I have noticed however is that the "Open" and "Closed" tags are both blue in the Projects interface when using the "Dark Protanopia & Deuteranopia" theme. However, they are blue and green when using "Dark default".

Dark Protanopia & Deuteranopia

Dark default

However, as a side note, I have to say the colourblind themes are a godsend for PR change comparisons and I will continue to use these themes just for that.

[cehfisher]

Hello @Esaron - thank you for providing this feedback! We will file this with our Accessibility team so that it can be reviewed and will follow-up here with any additional questions or updates. Thanks again!