Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet packages are including Labs-Only Source Generators #78

Closed
michael-hawker opened this issue Apr 20, 2022 · 0 comments · Fixed by #80
Closed

NuGet packages are including Labs-Only Source Generators #78

michael-hawker opened this issue Apr 20, 2022 · 0 comments · Fixed by #80

Comments

@michael-hawker
Copy link
Member

The NuGet packages we're outputting are including our Labs-only source generators:

image

This makes them unusable/consumable by others.

This is because they're being included in the Labs.MultiTarget.props file used by the library projects:

<!-- Source generator props -->
<ItemGroup>
<ProjectReference Include="$(RepositoryDirectory)\common\CommunityToolkit.Labs.Core.SourceGenerators.XamlNamedPropertyRelay\CommunityToolkit.Labs.Core.SourceGenerators.XamlNamedPropertyRelay.csproj"
OutputItemType="Analyzer" ReferenceOutputAssembly="True" />
<ProjectReference Include="$(RepositoryDirectory)\common\CommunityToolkit.Labs.Core.SourceGenerators\CommunityToolkit.Labs.Core.SourceGenerators.csproj"
OutputItemType="Analyzer" ReferenceOutputAssembly="True" />
</ItemGroup>

My current work is in this branch:
https://github.com/CommunityToolkit/Labs-Windows/tree/feature/sg-head-only

It wasn't working properly, but I may have fixed it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant