Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: brief appended to intro by mistake #250

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

xukai92
Copy link
Contributor

@xukai92 xukai92 commented Sep 3, 2023

brief has been appended to the end of intro by mistake
this pr fixes this

bug screenshot (see the selected part):
image

@Roger-luo
Copy link
Collaborator

Good catch thanks! Just need to wait for CI pass.

FYI the Julia version of Ion has been abandoned see also https://discourse.julialang.org/t/ann-the-ion-command-line-for-julia-developers-written-in-rust/94495/1

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/ast/printing.jl 0.00%

📢 Thoughts on this report? Let us know!.

@xukai92
Copy link
Contributor Author

xukai92 commented Sep 3, 2023

FYI the Julia version of Ion has been abandoned ...

Thanks for pointing this out.
I was checking Ion.jl mostly to make sure what I saw in my own CLI project with Comonicon was really bug (that also appears in another CLI project) but not something I did wrong.

@xukai92
Copy link
Contributor Author

xukai92 commented Sep 3, 2023

is the failed CI related to my PR?
i tested it locally with the main branch and see the same error in CI.

@Roger-luo
Copy link
Collaborator

Indeed seems due to #244 not updating the printing tests, I'll merge this one first

@Roger-luo Roger-luo merged commit f1e069c into comonicon:main Sep 3, 2023
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants