-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support weakdeps #252
Support weakdeps #252
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Ah right, thanks! The building procedure uses a hack to create a build env based on your test and project env. Can you add a test project test to check if this works in the test suite? You can add a weakdeps in this example project https://github.com/comonicon/Comonicon.jl/tree/main/example/FakePkg and you can modify the tests in that package. |
a29f590
to
7834ed7
Compare
Thanks! |
Ok, pushed another commit, this should fix the Julia 1.6 tests |
Ok pushed a fix for Julia 1.6 again, could you restart the CI? Thanks! |
I think the code is fine now, but it seems the coverage of
from the |
Thanks fine it's not much, thanks! |
Hi, thanks for sharing the package!
Julia 1.9 introduces package extension, it seems Comonicon does not support this yet?
I just tried to come up with a quick hack, and it seems working fine in my case. Would be great if someone could have a look at this PR (maybe use this as a hint), and properly support this Julia feature in Comonicon. Thanks!