Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues to address following initial release #12

Open
marcransome opened this issue Aug 23, 2019 · 0 comments
Open

Issues to address following initial release #12

marcransome opened this issue Aug 23, 2019 · 0 comments

Comments

@marcransome
Copy link

marcransome commented Aug 23, 2019

The following issues need addressing, as agreed, after the initial release of this service:

  • Replace list of variables in README.md with Markdown table as per other repositories
  • Remove manual terraform instructions from README.md
  • Remove outdated references to stage variable in README.md
  • Remove references to unused app_env_directory variable
  • Rename arn variable used in cloud-watch module to provide additional context (e.g. lambda_arn)
  • Replace hard-coded cron expression in aws_cloudwatch_event_rule resource with variable and rename any Terraform resources with time-specific names (e.g. payment_reconciler_daily and call_payment_reconciler_lambda_everyday) to decouple these from the variable cron expression
  • Update s3_key in aws_lambda_function resource to use workspace_key_prefix (i.e. "${var.workspace_key_prefix}/${var.service}-${var.release_version}.zip")

Speak to @marcransome or @Jata2k for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant