You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following issues need addressing, as agreed, after the initial release of this service:
Replace list of variables in README.md with Markdown table as per other repositories
Remove manual terraform instructions from README.md
Remove outdated references to stage variable in README.md
Remove references to unused app_env_directory variable
Rename arn variable used in cloud-watch module to provide additional context (e.g. lambda_arn)
Replace hard-coded cron expression in aws_cloudwatch_event_rule resource with variable and rename any Terraform resources with time-specific names (e.g. payment_reconciler_daily and call_payment_reconciler_lambda_everyday) to decouple these from the variable cron expression
Update s3_key in aws_lambda_function resource to use workspace_key_prefix (i.e. "${var.workspace_key_prefix}/${var.service}-${var.release_version}.zip")
The following issues need addressing, as agreed, after the initial release of this service:
README.md
with Markdown table as per other repositoriesREADME.md
stage
variable inREADME.md
app_env_directory
variablearn
variable used incloud-watch
module to provide additional context (e.g.lambda_arn
)aws_cloudwatch_event_rule
resource with variable and rename any Terraform resources with time-specific names (e.g.payment_reconciler_daily
andcall_payment_reconciler_lambda_everyday
) to decouple these from the variable cron expressions3_key
inaws_lambda_function
resource to useworkspace_key_prefix
(i.e."${var.workspace_key_prefix}/${var.service}-${var.release_version}.zip"
)Speak to @marcransome or @Jata2k for further details.
The text was updated successfully, but these errors were encountered: