client: mobile compilation fixes #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 16, 2023 18:30
Needed to make the android version compile.
Many of the types can't be correctly compiled into a public type by gomobile, so hide them as they're only used by serializing/deserializing into json.
These changes are needed so that gomobile may compile the lib.
This moves notification handling from the desktop to the generic class, as it will be shared between both desktop and mobile.
This path changes on every app recompilation, so do not save it in the bruig.conf but instead rely on the default app data dir to point to the correct location.
alexlyp
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still on initial test. doesn't work with go 1.20, only 1.19.5.