client: Filter historical logs as well #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki-totefu
reviewed
Nov 14, 2023
client/client.go
Outdated
Comment on lines
879
to
882
| gcID, err = c.GCIDByName(gcName) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
unneeded
uid is already gcID due to how this function is called. maybe this function should be renamed to ReadHistoryMessages
miki-totefu
reviewed
Nov 14, 2023
| if gcName == "" { | ||
| filter, _ = c.shouldFilter(uid, nil, nil, nil, entry.Message) | ||
| } else { | ||
| userID, err := c.UIDByNick(entry.From) |
There was a problem hiding this comment.
renames/aliasing will break this but it cant be helped because of how logs are stored...
There was a problem hiding this comment.
Right I had considered that a while back when working on the original impl for the log history. Hrm maybe we can somehow store past correlated names in the db? But a whole can of worms then for a relatively minor improvement I suppose
miki-totefu
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.