New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new extension point for declaring rhino installable packages #200
Conversation
@@ -2,26 +2,15 @@ | |||
from __future__ import division | |||
from __future__ import print_function | |||
|
|||
import compas_rhino.install | |||
import compas.plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of compas has compas.plugins? I think you might need to update the dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! I was actually a bit surprised this passes the build, but it's only because we don't test the rhino installer on CI.
The dependency needs to be updated, but right now, there's no release of compas
containing this extension point. I was hesitating whether to add (a significant chuck of) code to handle releases before and after this extension point exists but it would only be useful for a very brief amount of time, so, I think it's best to just hold this PR until there's a release of compas, update the dependency there, and keep less code around.
|
This PR should fix the issue mentioned above ☝️ @beverlylytle what do you think? ready to merge? |
Yep. |
This PR uses the changes on compas-dev/compas#614 to remove the install/uninstall scripts and instead use the new extension points.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_fab.robots.Configuration
.