Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support Node.js 18 #1778

Merged
merged 1 commit into from Apr 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions .env
@@ -1,16 +1,13 @@
NODE_ENV=development
APP_NAME=compas

POSTGRES_HOST=localhost:5432
POSTGRES_HOST=127.0.0.1:5432
POSTGRES_USER=postgres
POSTGRES_PASSWORD=postgres

MINIO_URI=localhost
MINIO_URI=127.0.0.1
MINIO_PORT=9000
MINIO_ACCESS_KEY=minio
MINIO_SECRET_KEY=minio123

CORS_URL=http://localhost:3000
COOKIE_URL=compas.test.dev
PROXY_URL=https://compas-e2e.dirkdevisser.dev
API_URL=http://localhost:4000
2 changes: 1 addition & 1 deletion .github/workflows/main-checks.yml
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [16, 17]
node: [16, 18]
postgres_version: [12, 13]
runs-on: ${{ matrix.os }}
env:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr-checks.yml
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [16]
node: [16, 18]
runs-on: ${{ matrix.os }}
env:
CI: true
Expand All @@ -33,7 +33,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [16, 17]
node: [16, 18]
postgres_version: [12, 13]
runs-on: ${{ matrix.os }}
env:
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [16]
node: [18]
runs-on: ${{ matrix.os }}
env:
CI: true
Expand Down
4 changes: 2 additions & 2 deletions docs/features/postgres-and-minio.md
Expand Up @@ -52,11 +52,11 @@ following to you `.env` file:
```txt
APP_NAME=compastodo
# Postgres
POSTGRES_HOST=localhost:5432
POSTGRES_HOST=127.0.0.1:5432
POSTGRES_USER=postgres
POSTGRES_PASSWORD=postgres
# Minio
MINIO_URI=localhost
MINIO_URI=127.0.0.1
MINIO_PORT=9000
MINIO_ACCESS_KEY=minio
MINIO_SECRET_KEY=minio123
Expand Down
2 changes: 1 addition & 1 deletion docs/references/cli.md
Expand Up @@ -92,7 +92,7 @@ a time.

PostgreSQL credentials:

> postgresql://postgres:postgres@localhost:5432/postgres
> postgresql://postgres:postgres@127.0.0.1:5432/postgres

Minio credentials:

Expand Down