Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint-config): remove no-return-await add require-await #752

Merged
merged 1 commit into from Mar 17, 2021

Conversation

dirkdev98
Copy link
Member

There is no built-in rule or rule plugin that adds more of these best practices. So follow this one for now.

This should improve the stacktrace in async scenarios

Closes #751

There is no built-in rule or rule plugin that adds more of these best practices. So follow this one for now.

This should improve the stacktrace in async scenarios

Closes #751
@dirkdev98 dirkdev98 enabled auto-merge (squash) March 17, 2021 15:38
@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 66.92% ( 28452/42516 )
Branches : 63.67% ( 3116 /4894 )
Functions : 68.25% ( 935 /1370 )
Lines : 66.92% ( 28452 /42516 )

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    9405  ns/op
router - github path params              100000  iterations   11226  ns/op
compas validator simple                 5000000  iterations     278  ns/op
yup validator simple                     100000  iterations   13123  ns/op
fastest-validator validator simple     10000000  iterations     123  ns/op
compas validator nested                 1000000  iterations    1481  ns/op
yup validator nested                      50000  iterations   41041  ns/op
fastest-validator validator nested      2000000  iterations     599  ns/op
logger - strings                         500000  iterations    3023  ns/op
logger - objects                         500000  iterations    3578  ns/op
logger - deep objects                    500000  iterations    5988  ns/op
uuid                                    5000000  iterations     398  ns/op
uuid.isValid                           10000000  iterations     163  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                          50000000  iterations      21  ns/op

@dirkdev98 dirkdev98 merged commit f00aa30 into main Mar 17, 2021
@dirkdev98 dirkdev98 deleted the feat/require-await branch March 17, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint-config: force await before return
1 participant