Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix build on FreeBSD by linking to libc++#31

Merged
Keats merged 1 commit into
compass-rs:masterfrom
Freaky:fix-freebsd
Aug 4, 2018
Merged

Fix build on FreeBSD by linking to libc++#31
Keats merged 1 commit into
compass-rs:masterfrom
Freaky:fix-freebsd

Conversation

@Freaky

@Freaky Freaky commented Aug 4, 2018

Copy link
Copy Markdown
Contributor

Maybe this conditional would be better off asking if we're using clang/gcc, but this fixes linking for me and allows cargo test to pass.

@Keats Keats merged commit 3c1524c into compass-rs:master Aug 4, 2018
@Keats

Keats commented Aug 4, 2018

Copy link
Copy Markdown
Collaborator

Thanks!

@Keats

Keats commented Aug 4, 2018

Copy link
Copy Markdown
Collaborator

I just realised, we define a is_bsd variable above in the build. We should use that instead of just special-casing freebsd no?

@valpackett

Copy link
Copy Markdown

Assuming libc++ if clang is the compiler doesn't sound right. Assuming libc++ on any BSD… I think most have switched at this point, yeah.

I guess the smart thing would be to use the c preprocessor to check for __GLIBCXX__ and such?

@Keats

Keats commented Aug 4, 2018

Copy link
Copy Markdown
Collaborator

Can I get some eyes on #32 by any chance? I'm not good with this kind of stuff

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants