Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on FreeBSD by linking to libc++ #31

Merged
merged 1 commit into from Aug 4, 2018
Merged

Conversation

@Freaky
Copy link
Contributor

@Freaky Freaky commented Aug 4, 2018

Maybe this conditional would be better off asking if we're using clang/gcc, but this fixes linking for me and allows cargo test to pass.

@Keats Keats merged commit 3c1524c into compass-rs:master Aug 4, 2018
2 checks passed
@Keats
Copy link
Collaborator

@Keats Keats commented Aug 4, 2018

Thanks!

@Keats
Copy link
Collaborator

@Keats Keats commented Aug 4, 2018

I just realised, we define a is_bsd variable above in the build. We should use that instead of just special-casing freebsd no?

@unrelentingtech
Copy link

@unrelentingtech unrelentingtech commented Aug 4, 2018

Assuming libc++ if clang is the compiler doesn't sound right. Assuming libc++ on any BSD… I think most have switched at this point, yeah.

I guess the smart thing would be to use the c preprocessor to check for __GLIBCXX__ and such?

@Keats
Copy link
Collaborator

@Keats Keats commented Aug 4, 2018

Can I get some eyes on #32 by any chance? I'm not good with this kind of stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants