Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class static initialization blocks support in Chrome 94 #1746

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy requested a review from ljharb August 2, 2021 23:50
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean i guess, but it seems premature before it's actually released - things get pulled from the release train all the time.

@chicoxyzzy
Copy link
Member Author

It works on Canary Version 94.0.4595.3 (Official Build) canary (x86_64) for me

@ljharb
Copy link
Member

ljharb commented Aug 3, 2021

Sure, but things can still be pulled from canary too. There’s no rush really, is there?

@chicoxyzzy
Copy link
Member Author

The proposal is enabled in Chrome 94 Dev and Canary is 95 now, so I think we can merge this now

@chicoxyzzy chicoxyzzy merged commit 201065c into compat-table:gh-pages Aug 18, 2021
@chicoxyzzy chicoxyzzy deleted the class_init_blocks_ch94 branch August 18, 2021 08:55
@ljharb
Copy link
Member

ljharb commented Aug 18, 2021

It’s fine, but I’d intended it to wait until release. Dev/canary don’t really count.

JLHwung pushed a commit to JLHwung/compat-table that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants