Spanish localization

[raulsperoni]

Hello!

First, let me say I think Pol.is is amazing, and since I've discovered the project I've been looking for an opportunity to use it.

I finally have an idea, so I will be deploying an instance of pol.is for several crowd experiments with Spanish speaker users (Uruguay). In that regard, I can see that you already have some Spanish translations but that doesn't get picked up by my browser.

Do you think something else needs to be done? I'm more than willing to make a PR in order to get this working.

Thank you!

[metasoarous]

Hi @raulsperoni. Thanks for asking about this, and for your kind feedback!

The Polis participation client should detect the default language setting on your browser, and use this to automatically present translated UI text accordingly (as well as present a button for automatically translating comments written in a different language). If this is not happening, it's possible that this is due to sub-language specificity in the language code not matching the "default" Spanish language code.

Our Spanish language translations are here: https://github.com/compdemocracy/polis/blob/dev/client-participation/js/strings/es_la.js
The code that consumes/applies these translations is here: https://github.com/compdemocracy/polis/blob/dev/client-participation/js/strings.js

After reviewing the code briefly, it looks like any language code matching the regex /^es/ should use the file pointed to above. You can take a look at the code here:

https://github.com/compdemocracy/polis/blob/dev/client-participation/js/strings.js#L95-L97

Can you please verify your browser's language settings? If after doing so the default language is still not picked up, this may correspond to a bug which needs to be resolved, in which case I'm happy to convert this discussion to a GH issue.

Separately, I realize that different regional dialects of Spanish can be quite different, and would be open to supporting more fine grained regional locatization, as long as there are good fallbacks for when a more specific dialect doesn't match exactly. Feel free to open a technical issue for this if you think this should be supported. No guarantee that we'll be able to spend a significant amount of time on it, but this would be a great area for contribution if you or other's have the bandwidth for it.

Thanks again!

[raulsperoni]

Thanks for your reply @metasoarous. You are right, I didn't have Spanish as my preferred language and this is working fine. I will check if some specific translation is needed for Uruguay but I don't think so.

Thanks!

[metasoarous]

Excellent! Thanks for confirming.