define nginx ports to be overridable #1536
Conversation
codePau
requested review from
metasoarous and
ballPointPenguin
as code owners
There was a problem hiding this comment.
Thanks for submitting this!
This is great, but I would like for the defaults to match current behavior before merging.
If you have time, it would also be great to have this documented, either in the main README, or in https://github.com/compdemocracy/polis/blob/dev/docs/configuration.md. Having just gone through this yourself, please let us know where you would have found this option most helpful.
Thanks again!
.env
Outdated
| @@ -1 +1,2 @@ | |||
| TAG=dev | |||
| HTTP_PORT=2000 | |||
There was a problem hiding this comment.
This is great! But can we please leave the default HTTP port to 80?
I think it should be possible to set a different default in the docker-compose.dev.yml overlay if you want to have a dev-time port other than 80. However, I'd like for that default to be 5000, since this has been the historical default for the dev tooling.
|
I wanted to use this change, so went ahead and fixed it up, and am merging. Thanks again! |
|
Thanks @metasoarous! Yes this line was just for testing purposes. Glad that you moved forward with it and it's now merged. |
Issue #1300