[bug] The site doesn't render with firefox addon "BP Privacy Block All Font and Glyph Detection" enable.

[robinmoussu]

Everything is in the title. If you enable BP Privacy Block All Font and Glyph Detection addon on firefox, you will see that only the top banner is displayed.

Firefox 66.0.4 - 64 bits - archlinux (up-to-date as of today)

The following error can be found in the console:

jQuery.Deferred exception: document.fonts.values(...) is not iterable getAllowedFontFamily/allowedFonts<@https://godbolt.org/:33:25
getAllowedFontFamily@https://godbolt.org/:26:22
modifiedCssSetProperty@https://godbolt.org/:47:18
recursivelyModifyFonts@https://godbolt.org/:91:5
modifiedAppend@https://godbolt.org/:100:11
i</e.prototype._createDomElements@https://godbolt.org/vs/editor/editor.main.js:31:288960
i</e.prototype.read@https://godbolt.org/vs/editor/editor.main.js:31:288323
t.readCharWidths@https://godbolt.org/vs/editor/editor.main.js:31:290269
h</t._actualReadConfiguration@https://godbolt.org/vs/editor/editor.main.js:31:1063344
h</t.prototype.readConfiguration@https://godbolt.org/vs/editor/editor.main.js:31:1061517
p</t.prototype.readConfiguration@https://godbolt.org/vs/editor/editor.main.js:31:1065781
m</n.prototype._computeInternalOptions@https://godbolt.org/vs/editor/editor.main.js:31:1026768
m</n.prototype._recomputeOptions@https://godbolt.org/vs/editor/editor.main.js:31:1026355
t@https://godbolt.org/vs/editor/editor.main.js:31:1064488
b</t.prototype._createConfiguration@https://godbolt.org/vs/editor/editor.main.js:31:1429263
t@https://godbolt.org/vs/editor/editor.main.js:31:1081315
t@https://godbolt.org/vs/editor/editor.main.js:31:1427562
t@https://godbolt.org/vs/editor/editor.main.js:31:1437433
t@https://godbolt.org/vs/editor/editor.main.js:31:1629917
t@https://godbolt.org/vs/editor/editor.main.js:31:1632026
k/<@https://godbolt.org/vs/editor/editor.main.js:31:1687638
T@https://godbolt.org/vs/editor/editor.main.js:31:1687538
k@https://godbolt.org/vs/editor/editor.main.js:31:1687613
n@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:96:91339
o.prototype.codeEditorFactory@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:96:88855
o/<@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:96:86659
r.items.Component@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:63709
createContentItem@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:28777
_createContentItems@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:62371
r.items.AbstractContentItem@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:57478
r.items.Stack@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:73065
createContentItem@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:28777
_createContentItems@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:62371
r.items.AbstractContentItem@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:57478
r.items.RowOrColumn@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:66494
createContentItem@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:28777
_createContentItems@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:62371
r.items.AbstractContentItem@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:57478
r.items.Root@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:64620
_create@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:34735
init@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:27083
o@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:96:88008
@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:88:108194
h@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:37:25117
s/</d<@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:37:25422
n@https://godbolt.org/dist/bundle.09e22ac59aa5c4a2e41d.js:58:11065
 undefined

[RubenRBS]

Thanks for the report :)
I'll see what can be done to stop the site from not working at all with such extensions, because that's totally unintended
Sentry issue: COMPILER-EXPLORER-43V

[apmorton]

did some investigation on this.

The code triggering the extension is part of monaco. I haven't looked into why monaco is doing this, but I suspect it isn't for telemetry purposes.

However, the actual issue is caused by the extension.
I don't know if the extension would otherwise break the site if it was working correctly, but the extension is simply broken.

The offending line in the extensions source code:

for (var allowed of document.fonts.values())
    if (normalised == allowed) return true

This code just simply doesn't work in firefox.
Try pasting this into the firefox console:

for (var allowed of document.fonts.values()) console.log(allowed);

This, however, does work:

for (var allowed of document.fonts) console.log(allowed);

I suggest you contact the extension author so they can fix the issue if you intend to continue using it.

I think this issue can be closed (or upstreamed with monaco if you desire).

[robinmoussu]

Ok, I will contact the extention author. You caneclore this issue. Envoyé depuis ProtonMail mobile

…

-------- Message d'origine -------- On 15 juil. 2019 à 1:21 PM, Austin Morton a écrit :

did some investigation on this. The code triggering the extension is [part of monaco](https://github.com/microsoft/vscode/blob/013501950e78b9dde5c2e6ec3f2ddfb9201156b7/src/vs/editor/browser/config/charWidthReader.ts). I haven't looked into why monaco is doing this, but I suspect it isn't for telemetry purposes. However, the actual issue is caused by the extension. I don't know if the extension would otherwise break the site if it was working correctly, but the extension is simply broken. The offending line in the extensions source code: for ( var allowed of document . fonts . values ()) if (normalised == allowed) return true This code just simply doesn't work in firefox. Try pasting this into the firefox console: for ( var allowed of document . fonts . values ()) console . log (allowed); [image](https://user-images.githubusercontent.com/63636/61212574-b44f1200-a6d0-11e9-953b-aefb2b694b70.png) This, however, does work: for ( var allowed of document . fonts ) console . log (allowed); [image](https://user-images.githubusercontent.com/63636/61212614-cb8dff80-a6d0-11e9-8232-3e4e23cf9c09.png) I suggest you contact the extension author so they can fix the issue if you intend to continue using it. I think this issue can be closed (or upstreamed with monaco if you desire). — You are receiving this because you authored the thread. Reply to this email directly, [view it on GitHub](#1372), or [mute the thread](https://github.com/notifications/unsubscribe-auth/ABPJZY7QCGGHHYCAD2OTTNDP7RMUJANCNFSM4HLCJKKA).