Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code sharing URL generator #42

Closed
Manu343726 opened this issue Jan 13, 2014 · 12 comments
Closed

Improve code sharing URL generator #42

Manu343726 opened this issue Jan 13, 2014 · 12 comments

Comments

@Manu343726
Copy link

I have noticed that the share URL generator just inserts the code and the compiler settings in the URL.
That works, but for large code snippets and sites with limitted URL lengths (Yes Twitter/stackoverflow, I'm talking about you...) that URLs cannot be shared easily/directly.

It would be awesome if the web generates better (shorter) urls. I think that URLs are generated in that way because GCC explorer server does not host the sourcecode, only provides a compiler frontend. But would be great if the server push the code automatically to a web like pastebin.com, and when the URL is accessed, that code is pulled from that web and written in gcc-explorer automatically.

@auselen
Copy link
Contributor

auselen commented Feb 19, 2014

6816c58 tries to improve sharing a little bit with some compression. That doesn't give you a terrific ratio of improvement (2/3 after 1-2k size), but I think that was a low hanging fruit.

@mattgodbolt
Copy link
Member

Thanks to a patch supplied by Malcolm Rowe we at least now have goo.gl URL shortnening. The pastebin stuff is a great idea but requires a little more support for things like XSS. I'm going to leave this open still as it would be really nice to have.

@auselen
Copy link
Contributor

auselen commented Mar 16, 2014

readonly stuff makes it looks awful with chrome, was that necessary?

@mattgodbolt
Copy link
Member

How does it look to you? Looks just fine to me!

[image: Inline image 1]

On Sun, Mar 16, 2014 at 3:26 PM, Ali Utku Selen notifications@github.comwrote:

readonly stuff makes it looks awful with chrome, was that necessary?

Reply to this email directly or view it on GitHubhttps://github.com//issues/42#issuecomment-37769174
.

Matt

@auselen
Copy link
Contributor

auselen commented Mar 16, 2014

May be just make it a link instead of an input for intuitiveness?

@auselen
Copy link
Contributor

auselen commented Mar 16, 2014

when you move mouse over it to copy, mouse pointer turns into a no sign, select copy thing becomes ugly as well.

I couldn't capture screenshot with mouse pointer :) however your screenshot didn't show up as well in this thread.

@mattgodbolt
Copy link
Member

How bizarre - what platform are you on? On my Ubuntu laptop the mouse
pointer is a regular pointer when over the permalink box.

On Sun, Mar 16, 2014 at 3:30 PM, Ali Utku Selen notifications@github.comwrote:

when you move mouse over it to copy, mouse pointer turns into a no sign,
select copy thing becomes ugly as well.

I couldn't capture screenshot with mouse pointer :) however your
screenshot didn't show up as well in this thread.

Reply to this email directly or view it on GitHubhttps://github.com//issues/42#issuecomment-37769312
.

Matt

@auselen
Copy link
Contributor

auselen commented Mar 16, 2014

This one is a Win7, aero pointer stuff. Apparently it is called unavailable

http://fc07.deviantart.net/fs37/i/2008/246/a/8/Windows_Aero_Glass_Curve_by_yanomami.png

@mattgodbolt
Copy link
Member

That's really odd! The URL really ought to be non-editable but that
shouldn't make the pointer unavailable. I'll check in with my HTML expert
and see if we can fix it. Thanks for reporting the issue!

On Sun, Mar 16, 2014 at 3:37 PM, Ali Utku Selen notifications@github.comwrote:

This one is a Win7, aero pointer stuff. Apparently it is called unavailable

http://fc07.deviantart.net/fs37/i/2008/246/a/8/Windows_Aero_Glass_Curve_by_yanomami.png

Reply to this email directly or view it on GitHubhttps://github.com//issues/42#issuecomment-37769693
.

Matt

@mattgodbolt
Copy link
Member

Malcolm has supplied another patch which hopefully solves this issue! Let me know if there are still any issues.

@malcolmr
Copy link
Contributor

I assume this was fixed by #47?

@mattgodbolt
Copy link
Member

Closing; I believe it's fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants