[BUG]: external asm parser doesn't check return code #4469
Labels
Comments
|
Should probably crash on startup. I don't think we should fiddle around with runtime error detection or something. So add a file check here https://github.com/compiler-explorer/compiler-explorer/blob/main/lib/external-parsers/base.ts#L24 I think |
mattgodbolt
added a commit
that referenced
this issue
Dec 20, 2022
Errors now look like:
```
Internal Compiler Explorer error: Error: Internal error running asm parser:
./dump-and-parse.sh: line 4: /usr/local/bin/asm-parser: No such file or directory
at CEAsmParser.parseAsmExecResult (/home/matthew/dev/ce/compiler-explorer/lib/external-parsers/base.ts:77:19)
at CEAsmParser.objdumpAndParseAssembly (/home/matthew/dev/ce/compiler-explorer/lib/external-parsers/base.ts:101:21)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async DefaultCompiler.objdump (/home/matthew/dev/ce/compiler-explorer/lib/base-compiler.ts:414:31)
at async Promise.all (index 0)
at async DefaultCompiler.checkOutputFileAndDoPostProcess (/home/matthew/dev/ce/compiler-explorer/lib/base-compiler.ts:1356:16)
at async /home/matthew/dev/ce/compiler-explorer/lib/base-compiler.ts:2236:41
at async run (/home/matthew/dev/ce/compiler-explorer/node_modules/p-queue/dist/index.js:163:29)
Compiler returned: -1
```
which at least gives context on why the parsing failed.
Merged
|
I think it's still worth checking. If the process quits for other reasons (SEGV) etc, it's useful to know rather than getting a cryptic JSON parse message. |
|
I'll add the check too for earlier failing. |
mattgodbolt
added a commit
that referenced
this issue
Jan 24, 2023
* Fix #4469 Errors now look like: ``` Internal Compiler Explorer error: Error: Internal error running asm parser: ./dump-and-parse.sh: line 4: /usr/local/bin/asm-parser: No such file or directory at CEAsmParser.parseAsmExecResult (/home/matthew/dev/ce/compiler-explorer/lib/external-parsers/base.ts:77:19) at CEAsmParser.objdumpAndParseAssembly (/home/matthew/dev/ce/compiler-explorer/lib/external-parsers/base.ts:101:21) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async DefaultCompiler.objdump (/home/matthew/dev/ce/compiler-explorer/lib/base-compiler.ts:414:31) at async Promise.all (index 0) at async DefaultCompiler.checkOutputFileAndDoPostProcess (/home/matthew/dev/ce/compiler-explorer/lib/base-compiler.ts:1356:16) at async /home/matthew/dev/ce/compiler-explorer/lib/base-compiler.ts:2236:41 at async run (/home/matthew/dev/ce/compiler-explorer/node_modules/p-queue/dist/index.js:163:29) Compiler returned: -1 ``` which at least gives context on why the parsing failed. And per discussion with @partouf we'll blow up at construction time if the file isn't there, which means the above is more to cover "what if the tool dies".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If the external parser fails (e.g. not found) then the error code goes unchecked and the JSON parser tries to parse the error output as JSON, leading to odd issues.
Steps to reproduce
externalparser=CEAsmParserand aexternalparser.exe=/not/a/fileExpected behavior
Error message like "external asm parser failed: ...OUTPUT HERE" (e.g.
./dump-and-parse.sh: line 4: /usr/local/bin/asm-parser: No such file or directoryin my case)Reproduction link
Not applicable
Screenshots
Not applicable
Operating System
No response
Browser version
No response
The text was updated successfully, but these errors were encountered: