Fix Erlang compiler & convert it to typescript #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenRBS
changed the title
mattgodbolt
approved these changes
Oct 7, 2022
| @@ -1,7 +1,7 @@ | |||
| # Default settings for Erlang | |||
| compilers=&erlang | |||
| compilerType=erlang | |||
| versionFlag= | |||
| versionFlag=-noshell -eval io:fwrite("~s~n", [erlang:system_info(otp_release)]), halt(). | |||
There was a problem hiding this comment.
Oh blimey! You had to learn erlang for this!? :D
There was a problem hiding this comment.
Hahaha no! I copied the flags over from the original compiler class
|
this doesn't work, but i'll see if I can fix it in main |
|
Fixed in 9f8d2cd Though sidenote; I'm a bit confused now why this noshell eval code is in the optionsForFilter function, it seems not needed. But this was added from the beginning in #3094 .. so I don't know what the deal is |
|
Thank you so much Partouf. I did indeed not test it as I have no Erlang setup locally. Should have tested in staging, sorry! |
|
this is live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent refactors to base-lang broke it
Closes #4121