Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hide metadata option to LLVM pipeline #4243

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

OfekShilon
Copy link
Member

Following comments from @jeremy-rifkin and @jryans, this PR is an addition of an option to hide all IR metadata:

image

Notes:

  1. Names were changed from 'filter' to 'hide', seems more natural UI phrasing.
  2. This is not a superset of 'hide debug'. llvm-debug intrinsics are unfiltered by the new option - can be filtered by checking both old an new options.
  3. This filters also attribute-groups on function definitions, but not individual attributes.
  4. There's also a small addition to the 'hide debug' option - hiding rows that include debug-location which typically appear in later stages of the pipeline.
  5. Added a test too

@github-actions github-actions bot added the ui label Nov 5, 2022
@jeremy-rifkin jeremy-rifkin self-requested a review November 5, 2022 23:22
Copy link
Member

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for implementing this! Tested locally and looks good to me

Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, looks good to me as well! 😄

@jeremy-rifkin jeremy-rifkin merged commit db9b4f4 into compiler-explorer:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants