Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch settings in initializeGlobalDependent #4307

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Fetch settings in initializeGlobalDependent #4307

merged 2 commits into from
Nov 25, 2022

Conversation

RubenRBS
Copy link
Member

Avoids some duplication in code, even tho it does some unecessary work in some other panes

@github-actions github-actions bot added the ui label Nov 18, 2022
@RubenRBS
Copy link
Member Author

@partouf do you think this is a valuable tradeoff?

partouf
partouf approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@partouf partouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense

@RubenRBS RubenRBS merged commit f1a4f16 into main Nov 25, 2022
@RubenRBS RubenRBS deleted the rr/diff-colours branch November 25, 2022 11:41
mattgodbolt pushed a commit that referenced this pull request Dec 20, 2022
@RubenRBS @mattgodbolt
Fetch settings in initializeGlobalDependent (#4307)
37b011d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partouf partouf partouf approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RubenRBS @partouf