Fix crossgen2 arguments #4342
Merged
Fix crossgen2 arguments #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We passed files other than dlls in `-r`.
|
@mattgodbolt Now it works as expected.
|
mattgodbolt
reviewed
Nov 25, 2022
| @@ -180,7 +180,7 @@ class DotNetCompiler extends BaseCompiler { | |||
| const crossgen2Options = [ | |||
| crossgen2Path, | |||
| '-r', | |||
| path.join(bclPath, '*'), | |||
| path.join(bclPath, '/'), | |||
There was a problem hiding this comment.
We need a tailing / here.
mattgodbolt
approved these changes
Nov 25, 2022
mattgodbolt
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Fix crossgen2 arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass the directory instead of files as the input to
-r/cc: @mattgodbolt