refactor: renames the CompilerFilters type #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
lang-circt
lang-cuda
lang-hook
lang-jakt
lang-mlir
lang-pony
lang-racket
Closed
dkm
force-pushed
the
dkm/rename_compilers_filters
branch
2 times, most recently
from
2124eb1
to
0a15ead
Compare
|
Is this ready for a look, @dkm ? :) |
|
Yes it is @mattgodbolt . Sorry for the code churn, I wasn't expecting this to be so long. |
mattgodbolt
approved these changes
Nov 27, 2022
|
Looks like this needs to be rebased. Will do this tomorrow :) |
The type which probably started as a real enum of possible post filtering options now also includes options used for compilers' invocations. The type was already split, but the naming was not reflecting this in the other part of the code. This changes tries to apply a simple renaming to the type only (correponding variables are left as 'filters'). While doing so, some typing error were discovered around the GccDump feature. A fix for this will follow in a different PR. Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
dkm
force-pushed
the
dkm/rename_compilers_filters
branch
from
884a20e
to
c174f80
Compare
|
this is now live |
mattgodbolt
pushed a commit
that referenced
this pull request
Dec 20, 2022
The type which probably started as a real enum of possible post filtering options now also includes options used for compilers' invocations. The type was already split, but the naming was not reflecting this in the other part of the code. This changes tries to apply a simple renaming to the type only (corresponding variables are left as 'filters'). While doing so, some typing error were discovered around the GccDump feature. A fix for this will follow in a different PR. Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type which probably started as a real enum of possible post filtering options now also includes options used for compilers' invocations.
The type was already split, but the naming was not reflecting this in the other part of the code.
This changes tries to apply a simple renaming to the type only (correponding variables are left as 'filters').
While doing so, some typing error were discovered around the GccDump feature. A fix for this will follow in a different PR.
Signed-off-by: Marc Poulhiès dkm@kataplop.net