-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.net - compileToBinary fix #4353
Conversation
that's my point, i'm not using execution |
https://godbolt.org/z/9deeWGfGc there is no execution. output window is for compile, not execution and yet it is throwing |
That's weird. We should have set the |
that's because in live without this fix, the state is shared and the compileToBinary setting is never reset to false anymore |
Thanks for the fix. Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks mate!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the lint issues too please
const sdkBaseDir = path.join(path.dirname(compiler), 'sdk'); | ||
const sdkVersions = await fs.readdir(sdkBaseDir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah. right, merge conflict things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a manual thing we have to do, push some buttons, test on testing environment, make fixes, deploy to live, etc. So somewhere between an hour and 2 weeks depending on the admins schedules.
I guess we can just skip running crossgen2 if we are in execution-only mode? |
Probably. You'll need to copy the |
this is now live |
with yesterday's container, it seems. latest one is https://github.com/compiler-explorer/compiler-workflows/actions/runs/3569737898 |
installation happens at a later point during the night, in about 5 hours |
it wasn't updated. still using the one from day before yesterday |
Latest is now installed. There were a couple things wrong with the build and install script |
Removes shared variable that would conflict with simultaneous compilations
Also ups pids max because of an issue I was hitting locally