Various enhancements for dotnet #4362
Conversation
hez2010
commented
Nov 29, 2022
hez2010
commented
- Split execution and compilation to avoid unnecessary crossgen2 run
- Add nuget packages support
|
Hi! Thanks for improving .net, we appreciate it. We're having trouble internally keeping up with so many changes (Which is a lovely problem to have, we appreciate all the effort and don't want to discurage anyone from submitting PRs!), so we might take a bit until we can confidently merge any more .net PRs, at least until we understand how it all fits together now. If you have any more PRs in the pipeline we'd appreciate if you could merge them all into one so we can take a look at it once we're ready to review them in a few weeks, thanks :) |
|
Having said that, once you change the suggested thing in the config, this one looks good to merge |
|
Hello, any chance to get this PR merged? It should improve the execution-only mode a lot by avoid running crossgen2. |
|
I'll take a look if not later today, then tomorrow! Thanks for your patience, appreciated your kind and gentle ping on this! |
etc/config/csharp.amazon.properties
Outdated
| @@ -5,6 +5,7 @@ compilerType=csharp | |||
| defaultCompiler=dotnet700csharp | |||
|
|
|||
| group.csharp.compilers=dotnettrunkcsharp:dotnet700csharp:dotnet6011csharp | |||
| group.csharp.nugetPackages=/opt/compiler-explorer/dotnet-nuget | |||
There was a problem hiding this comment.
I don;t see this directory on our network share:
Dec/26 22:51 admin-node~ $ ls -ld /opt/compiler-explorer/dotnet-*
lrwxrwxrwx 1 root root 21 Dec 26 07:35 /opt/compiler-explorer/dotnet-trunk -> dotnet-trunk-20221226
drwxr-xr-x 10 root root 22528 Dec 19 07:23 /opt/compiler-explorer/dotnet-trunk-20221219
drwxr-xr-x 10 root root 22528 Dec 20 07:31 /opt/compiler-explorer/dotnet-trunk-20221220
drwxr-xr-x 10 root root 22528 Dec 21 07:32 /opt/compiler-explorer/dotnet-trunk-20221221
drwxr-xr-x 10 root root 22528 Dec 22 07:31 /opt/compiler-explorer/dotnet-trunk-20221222
drwxr-xr-x 10 root root 22528 Dec 23 07:29 /opt/compiler-explorer/dotnet-trunk-20221223
drwxr-xr-x 10 root root 22528 Dec 25 07:37 /opt/compiler-explorer/dotnet-trunk-20221224
drwxr-xr-x 10 root root 22528 Dec 26 07:35 /opt/compiler-explorer/dotnet-trunk-20221226
drwxr-xr-x 3 root root 6144 Nov 25 07:21 /opt/compiler-explorer/dotnet-v6.0.1
drwxr-xr-x 9 root root 22528 Nov 25 23:00 /opt/compiler-explorer/dotnet-v6.0.11
drwxr-xr-x 9 root root 22528 Nov 25 22:59 /opt/compiler-explorer/dotnet-v7.0.0
What does this refer to?
There was a problem hiding this comment.
should probably be /opt/compiler-explorer/dotnet_nuget-v6.0.0
There was a problem hiding this comment.
$ ls -l /opt/compiler-explorer/dotnet_nuget-v6.0.0/packages/
total 0
drwxrwxr-x 3 root root 28 Jan 31 2022 fsharp.core
drwxrwxr-x 3 root root 28 Jan 29 2022 microsoft.aspnetcore.app.runtime.linux-x64
drwxrwxr-x 3 root root 28 Jan 29 2022 microsoft.netcore.app.runtime.linux-x64
There was a problem hiding this comment.
I don't understand the reference to the non-existent nugetPackages directory.
It's reserved for the future. Currently we don't have the directory existing.
If we want to provide nuget packages support, we can create the directory from the infra in the future.
dotnet build won't fail for a non-existent nuget source.
There was a problem hiding this comment.
Can we remove it please? There's no need to reserve anything for the future, we can make a change later to add it just as you've done here. Right now it's confusing and doesn't add anything.
There was a problem hiding this comment.
Thanks; testing locally now.
There was a problem hiding this comment.
Worked! will merge. thanks for your patience.
