First pass ts conversion for lib/mapfiles #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-rifkin
commented
Dec 2, 2022
| endAddress?: string; | ||
| segmentLength: number; | ||
| unitName?: string | false; | ||
| }; |
There was a problem hiding this comment.
I'm not in love with the types yet, but they work
There was a problem hiding this comment.
@partouf do these types look ok to you?
| segments: Segment[] = []; | ||
| isegments: Segment[] = []; | ||
| namedAddresses: Segment[] = []; | ||
| entryPoint: '' | EntryPoint = ''; |
There was a problem hiding this comment.
entryPoint appears unused but I'm trying to keep changes minimal
| * @returns {(object | boolean)} | ||
| */ | ||
| getLineInfoByAddress(segment, address) { | ||
| getLineInfoByAddress(segment: string | boolean, address: number) { | ||
| for (let idx = 0; idx < this.lineNumbers.length; idx++) { |
There was a problem hiding this comment.
Lots of index-based loops in this code but again trying to keep changes minimal
There was a problem hiding this comment.
It was written a long time ago in 2017, I just did what I knew would work :D
There was a problem hiding this comment.
Perfect for 2017! :P
|
this is live 🚀 |
mattgodbolt
pushed a commit
that referenced
this pull request
Dec 20, 2022
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.