Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Josuttis' Belle Views to C++ compiler #4452

Merged
merged 2 commits into from
Dec 18, 2022
Merged

Add Josuttis' Belle Views to C++ compiler #4452

merged 2 commits into from
Dec 18, 2022

Conversation

correaa
Copy link
Contributor

@correaa correaa commented Dec 18, 2022

RubenRBS
RubenRBS approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

etc/config/c++.amazon.properties Outdated Show resolved Hide resolved
@RubenRBS RubenRBS self-requested a review December 18, 2022 16:51
RubenRBS
RubenRBS requested changes Dec 18, 2022
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes instead of acepting

@correaa @RubenRBS
Update etc/config/c++.amazon.properties
ffda9fa 
Co-authored-by: Rubén Rincón Blanco <ruben@rinconblanco.es>
@correaa
Copy link
Contributor Author

correaa commented Dec 18, 2022

Meant to request changes instead of acepting

I agree with the change.

@RubenRBS RubenRBS merged commit d5a9bae into compiler-explorer:main Dec 18, 2022
@correaa
Copy link
Contributor Author

correaa commented Dec 18, 2022

thanks. good day today🇦🇷.

@jeremy-rifkin
Copy link
Member

This is now live

@correaa
Copy link
Contributor Author

correaa commented Dec 19, 2022

And it works now: https://godbolt.org/z/dqboqEbfh.

@josuttis

@correaa correaa deleted the add_jossutis_belleviews branch December 19, 2022 17:57
mattgodbolt pushed a commit that referenced this pull request Dec 20, 2022
@correaa @mattgodbolt
Add Josuttis' Belle Views to C++ compiler (#4452)
147bfa0
mattgodbolt pushed a commit that referenced this pull request Jan 24, 2023
@correaa @mattgodbolt
Add Josuttis' Belle Views to C++ compiler (#4452)
fac6f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenRBS RubenRBS RubenRBS approved these changes

Assignees
No one assigned
Labels
lang-c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@correaa @jeremy-rifkin @RubenRBS