Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rust crates #4462

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Add new rust crates #4462

merged 3 commits into from
Dec 19, 2022

Conversation

RubenRBS
Copy link
Member

This adds Subtle #4449 and Rayon #3927

@partouf
Copy link
Contributor

partouf commented Dec 19, 2022

They seem to have been built, but they do not appear here yet https://conan.compiler-explorer.com/libraries_rust.html because that page doesn't know it's rust yet because the properties have not been merged yet.

Most do appear here https://conan.compiler-explorer.com/libraries.html and it looks ok I think.

Eyre does not work however https://conan.compiler-explorer.com/getlogging/20221217055651 it seems to require something pythonish (python does get installed on the builder https://github.com/compiler-explorer/library-builder/blob/main/Dockerfile#L34)
Let's leave that one out for now

@partouf
Copy link
Contributor

partouf commented Dec 19, 2022

I think here's the instructions for building pyo3 correctly, but it's a bit wall of texty https://github.com/PyO3/pyo3/blob/101ac1b78d5ef13f834f211bc1ad95624a433f98/guide/src/building_and_distribution.md

@partouf
Copy link
Contributor

partouf commented Dec 19, 2022

maybe it's just a matter of setting PYO3_PYTHON?

@partouf partouf merged commit d0577c6 into main Dec 19, 2022
@partouf partouf deleted the rr/add-new-rust-crates branch December 19, 2022 16:41
mattgodbolt pushed a commit that referenced this pull request Dec 20, 2022
mattgodbolt pushed a commit that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants