Tsify lib/storage #4499
Merged
Tsify lib/storage #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-rifkin
commented
Dec 27, 2022
| // declarations." | ||
| // Updating profanities to v3 requires ESM modules | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires, unicorn/prefer-module | ||
| const profanities = require('profanities'); |
There was a problem hiding this comment.
I'm not sure if there's another way to do this. I could not get any import working.
There was a problem hiding this comment.
profanities is another lib we can't upgrade because of ESM, so... one day this will probably be ok.
jeremy-rifkin
commented
Dec 27, 2022
mattgodbolt
approved these changes
Dec 28, 2022
| @@ -122,7 +128,7 @@ export class StorageS3 extends StorageBase { | |||
| const subHashes = _.chain(data.Items).pluck('unique_subhash').pluck('S').value(); | |||
| const fullHashes = _.chain(data.Items).pluck('full_hash').pluck('S').value(); | |||
| for (let i = MIN_STORED_ID_LENGTH; i < hash.length - 1; i++) { | |||
| let subHash = hash.substring(0, i); | |||
| const subHash = hash.substring(0, i); | |||
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 4, 2023
* Tsify lib/storage * Add @types/request * Fix get/post types * Better type solution
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Tsify lib/storage * Add @types/request * Fix get/post types * Better type solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.