Tsify lib/shorteners #4504
Merged
Tsify lib/shorteners #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-rifkin
commented
Dec 28, 2022
| if (!err && resp.statusCode === 200) { | ||
| res.send({url: body}); | ||
| } else { | ||
| res.status(resp.statusCode).send(resp.error); | ||
| res.status(resp.statusCode).send('Tinyurl error'); |
There was a problem hiding this comment.
resp.error isn't a thing according to the types
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 4, 2023
* Convert lib/shorteners to ts * Improved types
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Convert lib/shorteners to ts * Improved types
moha-gh
added a commit
to moha-gh/compiler-explorer
that referenced
this pull request
Jul 19, 2023
The file has been converted to a TypeScript module in compiler-explorer#4504 and the link to it in README.md has not been updated then. Fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.