Fixcrashissue #4518
Merged
Fixcrashissue #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 4, 2023
* await for conan downloads * await later This fixes #4512 - essentially any exceptions thrown before the `await` of the build environment would leave a "task" that was trying to write to the temp dir. the temp dir would then be deleted, and the untar would fail, and as nobody was await-ing its return (as the awaits used to be _after_ the throwing code) then we'd get an uncaught exception.
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 24, 2023
* await for conan downloads * await later This fixes #4512 - essentially any exceptions thrown before the `await` of the build environment would leave a "task" that was trying to write to the temp dir. the temp dir would then be deleted, and the untar would fail, and as nobody was await-ing its return (as the awaits used to be _after_ the throwing code) then we'd get an uncaught exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.